Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deny config #2330

Merged
merged 1 commit into from Apr 9, 2023
Merged

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Apr 6, 2023

Motivation

  • Remove outdated exceptions and [[license.clarify]]
  • Make config more strict for wildcard and git dependencies
    • bad practice, git dependencies are not allowed when published so doesn't hurt adding an extra check
  • Add MPL-2.0 to license allow list since it generates a warning for being copy-left

The only remaining warnings are for duplicate crates

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

concurrency: deps-${{ github.head_ref || github.run_id }}

jobs:
deny:
name: deny (${{ matrix.checks }})
name: deny
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, we def don't need a matrix here if we use check all which does both

Copy link
Collaborator Author

@DaniPopes DaniPopes Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing I noticed about this is that if check advisories fails with an error, it will continue regardless, but then if the next matrix step succeeds the entire job succeeds, silencing the advisory error..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially took it from reth, should I update it there too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do, ty!

@prestwich prestwich merged commit a4bee08 into gakonst:master Apr 9, 2023
15 of 16 checks passed
@DaniPopes DaniPopes deleted the chore/update-deny branch April 10, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants