feat(solc): color when formatting Error and OutputDiagnostics #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Apr 21, 2023
DaniPopes
changed the title
DaniPopes
force-pushed
the
feat/better-solc-diags
branch
from
5dd4ce4
to
7561b7a
Compare
DaniPopes
force-pushed
the
feat/better-solc-diags
branch
from
7561b7a
to
0afbfae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Monotone color ugly and bad. More colors good.
Tried as much as possible to use the same format as Solc's formatter.
Before:
After (left:
solc --error-codes, right: this):Solution
PR Checklist