feat(solc): add support for Paris and Shanghai EVM versions #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Apr 29, 2023
Comment on lines
+769
to
+782
| } else if self >= Self::Paris && *version >= PARIS_SOLC { | ||
| Self::Paris | ||
| } else if self >= Self::London && *version >= LONDON_SOLC { | ||
| Self::London | ||
| } else if self >= Self::Berlin && *version >= BERLIN_SOLC { | ||
| Self::Berlin | ||
| } else if self >= Self::Istanbul && *version >= ISTANBUL_SOLC { | ||
| Self::Istanbul | ||
| } else if self >= Self::Petersburg && *version >= PETERSBURG_SOLC { | ||
| Self::Petersburg | ||
| } else if self >= Self::Constantinople && *version >= CONSTANTINOPLE_SOLC { | ||
| Self::Constantinople | ||
| } else if self >= Self::Byzantium { | ||
| Self::Byzantium |
There was a problem hiding this comment.
Swapped the conditions so the faster one is first.
Comment on lines
+862
to
+872
| "homestead" => Ok(Self::Homestead), | ||
| "tangerineWhistle" => Ok(Self::TangerineWhistle), | ||
| "spuriousDragon" => Ok(Self::SpuriousDragon), | ||
| "byzantium" => Ok(Self::Byzantium), | ||
| "constantinople" => Ok(Self::Constantinople), | ||
| "petersburg" => Ok(Self::Petersburg), | ||
| "istanbul" => Ok(Self::Istanbul), | ||
| "berlin" => Ok(Self::Berlin), | ||
| "london" => Ok(Self::London), | ||
| "paris" => Ok(Self::Paris), | ||
| "shanghai" => Ok(Self::Shanghai), |
There was a problem hiding this comment.
Reordered to match variant order.
DaniPopes
force-pushed
the
feat/paris-shanghai
branch
from
e4db70b
to
4c03841
Compare
DaniPopes
commented
Apr 29, 2023
|
|
||
| pub fn has_push0(&self) -> bool { | ||
| *self >= Self::Shanghai | ||
| } |
There was a problem hiding this comment.
gakonst
approved these changes
Apr 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Paris support was added in 0.8.18, and Shanghai support is on track to be released with 0.8.20.
Solution
PR Checklist