Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc ws fixes #2389

Merged
merged 3 commits into from May 7, 2023
Merged

Misc ws fixes #2389

merged 3 commits into from May 7, 2023

Conversation

jordy25519
Copy link
Contributor

Motivation

Some small fixes found while going through the ws code

  • to_raw_valuehelper is slightly more efficient
  • ws ping frames are handled transparently by tungstenite

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes
Copy link
Collaborator

I don't believe to_raw_value and RawValue::from_string are equivalent, see failing tests in CI: https://github.com/gakonst/ethers-rs/actions/runs/4842761312/jobs/8748645910?pr=2389
Can you please check again?

@jordy25519
Copy link
Contributor Author

I don't believe to_raw_value and RawValue::from_string are equivalent, see failing tests in CI: https://github.com/gakonst/ethers-rs/actions/runs/4842761312/jobs/8748645910?pr=2389 Can you please check again?

needed to remove the escape \ chars, checked tests are passing now

DaniPopes
DaniPopes approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks!

@DaniPopes DaniPopes merged commit e9568eb into gakonst:master May 7, 2023
15 checks passed
@jordy25519 jordy25519 deleted the misc-ws-fixes branch May 7, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jordy25519 @DaniPopes