Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move spoof module to ethers_core, add stateoverrides to GethDebugTracingCallOptions #2406

Merged
merged 3 commits into from May 23, 2023
Merged

feat: move spoof module to ethers_core, add stateoverrides to GethDebugTracingCallOptions #2406

merged 3 commits into from May 23, 2023

Conversation

georgewhewell
Copy link
Contributor

Motivation

i want to use stateoverrides in debug_traceCall

Solution

as described in #2298

  • move ethers_providers::types::geth::spoof module to ethers_core
  • add state_overrides to GethDebugTracingCallOptions

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

DaniPopes
DaniPopes approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added a re-export where the module was removed, to not break imports.

@DaniPopes DaniPopes merged commit 58fd3fe into gakonst:master May 23, 2023
14 of 16 checks passed
@DaniPopes DaniPopes mentioned this pull request May 23, 2023
Closed
@georgewhewell
Copy link
Contributor Author

nice, thanks for review @DaniPopes 👍

@georgewhewell georgewhewell deleted the grw/export-diffmode-add-overrides branch May 23, 2023 12:36
@DaniPopes DaniPopes mentioned this pull request May 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgewhewell @DaniPopes