New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(solc): set default EVM version to Shanghai #2414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reasonable.
we also have a new model setting
settings.modelChecker.showProvedSafe
and some AST changes
https://github.com/ethereum/solidity/releases/tag/v0.8.20
perhaps we should wait until svm added 0.8.20
CI partly blocked by SVM 0.8.20 support |
@@ -41,9 +41,7 @@ fn can_get_versioned_linkrefs() { | |||
.unwrap(); | |||
|
|||
let project = Project::builder().paths(paths).ephemeral().no_artifacts().build().unwrap(); | |||
|
|||
let compiled = project.compile().unwrap(); | |||
assert!(!compiled.has_compiler_errors()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I Can't comment on the file)
assert!(!compiled.has_compiler_errors());
->
compiled.assert_success();
for better message (prints self
when panicking)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, CI failures look tungesnite related
Yeah will open separately |
Motivation
https://blog.soliditylang.org/2023/05/10/solidity-0.8.20-release-announcement/
Solution
PR Checklist