feat(abigen): emit cargo build script directives #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
May 31, 2023
| let contents = fs::read_to_string(&path).wrap_err("Could not read file")?; | ||
|
|
||
| Self::new(name, contents) | ||
| let path = path.as_ref().to_str().ok_or_else(|| eyre::eyre!("invalid path"))?; |
There was a problem hiding this comment.
nit: error should include the path
| /// Specify whether to print [cargo build script directives][ref] if the source is a path. By | ||
| /// default, this is true only when executing inside of a build script. | ||
| /// | ||
| /// [ref]: https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script |
There was a problem hiding this comment.
I need to adapt this href style
| @@ -368,6 +396,11 @@ impl ContractBindings { | |||
| } | |||
| } | |||
|
|
|||
| /// Returns whether the current executable is a cargo build script. | |||
| fn in_build_script() -> bool { | |||
| std::env::var("CARGO_MAKEFLAGS").is_ok() | |||
There was a problem hiding this comment.
honestly i just went over all of the env vars, and this one was the only one that is set only on build scripts, per docs. Not 100% sure
There was a problem hiding this comment.
TARGET should be fine as well.
DaniPopes
force-pushed
the
feat/incremental-abigen
branch
2 times, most recently
from
89d392b
to
f6ce0d8
Compare
DaniPopes
force-pushed
the
feat/incremental-abigen
branch
from
f6ce0d8
to
235ffce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
... and an
include_bytes!when not in build scripts. Signals Cargo to rebuild if the source files change.Solution
PR Checklist