Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent panics decoding too short input #2470

Merged
merged 1 commit into from Jun 13, 2023
Merged

fix: prevent panics decoding too short input #2470

merged 1 commit into from Jun 13, 2023

Conversation

WestXu
Copy link
Contributor

@WestXu WestXu commented Jun 13, 2023

Got hit by a runtime panic on this. Simple fix.

mattsse
mattsse approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ethers-contract/src/base.rs Show resolved Hide resolved
@DaniPopes DaniPopes merged commit 57399b6 into gakonst:master Jun 13, 2023
18 of 19 checks passed
@WestXu WestXu deleted the patch-1 branch June 13, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WestXu @mattsse @DaniPopes