Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Stream performance #25

Merged
merged 2 commits into from Jun 17, 2020
Merged

Improve Stream performance #25

merged 2 commits into from Jun 17, 2020

Conversation

gakonst
Copy link
Owner

@gakonst gakonst commented Jun 17, 2020 •
edited

Motivation

Previously it'd run in an infinite loop.

Solution

Replace the infinite loop with a Poll::Pending return value, so that the runtime decides what to do with it

@gakonst gakonst merged commit a9d1be4 into master Jun 17, 2020
@gakonst gakonst deleted the fix/stream-perf branch June 17, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gakonst