Add aliases for TypedTransaction tags that work with Hardhat #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Jul 25, 2023
aakoshh
force-pushed
the
fix-typed-transaction-tag-0x2
branch
from
3e082f4
to
f3be43a
Compare
DaniPopes
requested changes
Jul 25, 2023
aathan
pushed a commit
to aathan/ethers-rs
that referenced
this pull request
Jul 27, 2023
…#2518) * Add aliases for TypedTransaction tags that work with Hardhat * Ignore TypedTransaction test in legacy mode. * Fix formatting errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@cryptoAtwill was testing an API that used
ethers_core::types::TypedTransactionon the server side to decode the JSON-RPC parameters of aneth_estimateGascall sent by Hardhat when he noticed that it was rejected due to the tag not being recognised. The reason was thatethersexpects"type": "0x02"while Hardhat sends"type": "0x2".I noticed that some of the tests actually contain
"0x2"but it's not used, so I thought this is a bug.Solution
The simple solution in this PR is to add an
aliasto theTypedTransactionvariants, so both padded and non-padded versions are accepted.PR Checklist