Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Etherscan beacon withdrawal transactions #2621

Merged
merged 3 commits into from Oct 18, 2023
Merged

feat: support Etherscan beacon withdrawal transactions #2621

merged 3 commits into from Oct 18, 2023

Conversation

Michael-A-Heuer
Copy link
Contributor

Motivation

The Etherscan API supports querying Beacon Chain Withdrawals by Address and Block Range since the Capella hardfork. However, this method is not supported by ethers-etherscan yet.

Solution

This PR adds the fn get_beacon_withdrawal_transactions and struct BeaconWithdrawalTransaction type.

PR Checklist

  • Added Tests
  • Added Documentation

@Michael-A-Heuer Michael-A-Heuer changed the title feat: support etherscan beacon withdrawal transaction queries feat: support Etherscan beacon withdrawal transactions Oct 2, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@DaniPopes DaniPopes merged commit 976f38c into gakonst:master Oct 18, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants