Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make ethers-ethercan optional in ethers-middleware #2672

Merged
merged 4 commits into from Nov 8, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

No reason to pull in this dep always

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes marked this pull request as ready for review November 8, 2023 19:13
@DaniPopes DaniPopes force-pushed the etherscan-middleware branch 2 times, most recently from a58a817 to 77bc08d Compare November 8, 2023 19:58
@DaniPopes DaniPopes merged commit 0543e1c into gakonst:master Nov 8, 2023
11 of 13 checks passed
@DaniPopes DaniPopes deleted the etherscan-middleware branch November 8, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants