chore: disable all ethers features by default and expose them individually #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* hook into step * debug steps * mvp * better fmting * fixes * fmt * clippy * updates * refactor * fmt * inner call support * source mapping :) * clippy and fmt * traces for a run cmd * source improvements * some cleanup * fix coloring * add constructor bytecode debugger * import fix * working sourcemap parsing * fixes * cargo lock * styling * comments * comments mostly * better structure + comments * dont compile when no project * nits + documentation * chore: update latest ethers utils (gakonst#394) * chore: update latest ethers utils * rustmft * updates primarily to run cmd * correct documentation * fix solang version -.- * refactor * fmt * fixes * better formatting * force recompile * ui update + gas tracking + known contracts fix Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393
Problem
We were bundling deps with
defaultfeatures in theetherscrate. This meant that IPC was getting included, which does not exist in windows.Fix
We disable all default features by default in
ethersand expose individual feature flags for each.