feat: add quorum provider #409
Conversation
|
for RPC calls that take a block height we need to ensure that all providers request info at the same height, preferably the minimum height across all providers this is like, |
|
Good point, |
gakonst
force-pushed
the
matt/quorum-provider
branch
from
ff60c0f
to
8d324ca
Compare
| total / 2 + rem | ||
| } | ||
| Quorum::Percentage(p) => { | ||
| providers.iter().map(|p| p.weight).sum::<u64>() * (p as u64) / 100 |
There was a problem hiding this comment.
Maybe add a if p > 100 { panic!() } here?
|
|
||
| fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> { | ||
| let this = self.get_mut(); | ||
| for n in (0..this.requests.len()).rev() { |
There was a problem hiding this comment.
Why are we iterating in reverse here?
There was a problem hiding this comment.
because how swap_remove works, which replaces the removed element with the last element. but this also means that if we'd start at 0 we would miss the value at the last index, therefor we need to start at the last index.
| use crate::{Middleware, MockProvider, Provider}; | ||
| use ethers_core::types::U64; | ||
|
|
||
| async fn test_quorum(q: Quorum) { |
Motivation
Support multiple provider endpoints
Solution
Adds the
QuorumProvidertype that can run internal multiple providers internally and only returns a response if a quorum was reached. The internal providers can be weighted.This required two Wrapper traits for
JsonRpcClientPubsubClientto get rid of the generic types.How a quorum is reached can be configured with
Quorum, default isQuorum::Majoritywhich reaches a quorum if >50% of the weighted providers returned the same value