Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, abi): support shorthand function declarations #472

Merged
merged 7 commits into from Sep 28, 2021

Conversation

shekhirin
Copy link
Contributor

Motivation

See #446

Solution

Support shorthand function declarations

@gakonst
Copy link
Owner

gakonst commented Sep 27, 2021

This is great. Thank you. Paging @mattsse in case he's available to review this, since he wrote the parser, otherwise I'll try to take a closer look tomorrow.

@shekhirin
Copy link
Contributor Author

shekhirin commented Sep 28, 2021

Another thing that may worth filing a new issue: redesign human readable ABI parsing, so it doesn't split the strings 9999 times but iterate the tokens instead 😄

@mattsse
Copy link
Collaborator

mattsse commented Sep 28, 2021

Definitely, when I first wrote this I used the internal ethabi parser as the basis for that.
Tokenization would be much nicer, but at least the human readable abi does only add to compile-time in abigen!
+1 for follow up issue, parts of solang could be useful for that,

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants