Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pending escalation broken by lack of availability of tx signing on middleware
Solution
Add
Middleware::sign_transaction
. It errors unless there is aSignerMiddleware
in the stack somewhere. Thefrom
field has no effect (matching behavior ofSignerMiddleware::sign
but is added to match theMiddleware::sign
API for potential future use.driveby: while testing escalation locally, hit an edge case with tx braodcast failing due to a previous escalation confirming during broadcast. Added a handler for that in the
Broadcasting
state transitionPR Checklist