Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prestwich/escalator fixes #581

Merged
merged 2 commits into from Nov 14, 2021
Merged

Prestwich/escalator fixes #581

merged 2 commits into from Nov 14, 2021

Conversation

prestwich
Copy link
Collaborator

Motivation

Pending escalation broken by lack of availability of tx signing on middleware

Solution

Add Middleware::sign_transaction. It errors unless there is a SignerMiddleware in the stack somewhere. The from field has no effect (matching behavior of SignerMiddleware::sign but is added to match the Middleware::sign API for potential future use.

driveby: while testing escalation locally, hit an edge case with tx braodcast failing due to a previous escalation confirming during broadcast. Added a handler for that in the Broadcasting state transition

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gakonst gakonst merged commit 0f22afe into master Nov 14, 2021
@gakonst gakonst deleted the prestwich/escalator-fixes branch November 14, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants