Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add buffer for file reading #662

Merged
merged 1 commit into from Dec 9, 2021
Merged

add buffer for file reading #662

merged 1 commit into from Dec 9, 2021

Conversation

laizy
Copy link
Contributor

@laizy laizy commented Dec 9, 2021

foundry-rs/foundry#198

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

mattsse
mattsse approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

I guess this is due to how serde reads from reader, the serde docs also use Bufreader.
lgtm

gakonst
gakonst approved these changes Dec 9, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catch.

@gakonst gakonst merged commit eeaab21 into gakonst:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laizy @gakonst @mattsse