Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solc): add hardhat artifact support #677

Merged
merged 6 commits into from Dec 11, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 11, 2021

Motivation

Add support for hardhat style artifacts
Closes #676

Solution

  • Add artifact bindings + handler
  • Add additional Artifacthandler MinimalCombinedArtifactsHardhatFallback that tries to deserialize hardhat artifacts if the previous attempt failed. Alternatively this behaviour could be moved to a bool flag in the existing MinimalCombinedArtifacts handler and enabled by default?

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - merging optimistically and we can iterate on it

@gakonst gakonst merged commit 275f717 into gakonst:master Dec 11, 2021
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
* feat: to_int256 function + doctests

* fix: handle larger int256 values

* chore: remove import

* feat: add to cli

* refactor: use more idiomatic rust

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethers-solc: support previous hardhat builds
2 participants