Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move FeeHistory to core types #688

Merged
merged 1 commit into from Dec 13, 2021
Merged

refactor: move FeeHistory to core types #688

merged 1 commit into from Dec 13, 2021

Conversation

prestwich
Copy link
Collaborator

Motivation

FeeHistory is out of place in ethers-providers, it should go in ethers_core::types with all its typesy friends

Solution

Move FeeHistory to ethers-core/src/types/fee.rs and update imports

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

gakonst
gakonst approved these changes Dec 13, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@gakonst gakonst merged commit 47e9e7d into master Dec 13, 2021
@gakonst gakonst deleted the prestwich/fee-history-type branch December 13, 2021 22:49
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
@ncitron
fix --gas-price flag (gakonst#688)
37b4cbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prestwich @gakonst