Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solc): revamped remapping auto detect #706

Merged
merged 1 commit into from Dec 19, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 18, 2021

Motivation

Better, faster remappings autodetection with more hardhat layouts in mind

Solution

optimize lib folder scanning, unify nested hardhat remappings.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand 100% the algo, but if the unit tests + new one pass I'm 👍

@gakonst gakonst merged commit 9096f4e into gakonst:master Dec 19, 2021
@mattsse mattsse mentioned this pull request Dec 19, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants