Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve library/import resolution #739

Closed
2 tasks
mattsse opened this issue Dec 25, 2021 · 0 comments · Fixed by #750
Closed
2 tasks

Improve library/import resolution #739

mattsse opened this issue Dec 25, 2021 · 0 comments · Fixed by #750

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 25, 2021

Is your feature request related to a problem? Please describe.
Currently, resolving libraries is very primitive and basically only supports lookups in the configured lib folder without applying remappings.

Essentially all imports outside of the src directory rely on remappings so solc can apply them.
This means, they're not part of the cache since we don't discover them properly. Therefor changes in lib contracts can be skipped if caching is enabled

Likely the case here foundry-rs/foundry#299
also definitely related #727

Describe the solution you'd like
Short term:

  • resolve remappings in resolve_libraries.
  • check all imports contracts for changes when checking a CacheEntry

Long term, add a proper dependency graph implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant