Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generalize wallet/private key #75

Merged
merged 3 commits into from Oct 2, 2020
Merged

feat: generalize wallet/private key #75

merged 3 commits into from Oct 2, 2020

Conversation

gakonst
Copy link
Owner

@gakonst gakonst commented Oct 1, 2020 •
edited

  • Allows the Wallet struct to be generic over DigestSigner.
  • The private/public key types inside ethers-core are removed
  • A private-key based type alias is exposed via ethers::signers::LocalWallet
  • YubiHSM2 Support (YubiHSM2 Support #76)

@gakonst gakonst merged commit aa37f74 into master Oct 2, 2020
@gakonst gakonst deleted the ecdsa-signer branch October 2, 2020 08:41
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
@gakonst
feat: handle & print reverts on failing EVM execution (gakonst#75)
704eb30 
* feat: return error and decode retdata on evm reverts

* chore: return concrete error type in decode_revert

* feat(evm): return revert reason and gas used on failed execution

* feat(dapp): handle reverts and return reason in test result

* feat(cli): print revert reason for failing tests when possible

* fix(utils): return 'No revert reason found' if no revert string is specified

* fix(evm): check error variant strictly instead of string cmp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gakonst