New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RLP decoding for transactions #805
Conversation
Seems like something is missing when testing against a live network? failures: 282 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directionally this looks great - just think there's some decoding bug in testnet so i'd look at that
@Rjected hey just checking up here, what do your plans look like for getting this over the line? can we help? |
Didnt dive into code, but maybe this can help (or at least act as reference). It is impl of types transaction with good licence: |
Hey, yeah I have been pretty busy but I fixed the failing tests. Since the workflow needs to be approved, here's the workflow on my fork: https://github.com/Rjected/ethers-rs/actions/runs/1763919095. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sick
Motivation
Currently there is no way to decode a transaction from bytes, only encode to bytes.
Solution
Implemented the
Decodable
trait for:TypedTransaction
TransactionRequest
Eip2930TransactionRequest
Eip1559TransactionRequest
NameOrAddress
Transaction
This change uses
rlp_derive
for theDecodable
implementation onAccessListItem
andAccessList
.This also adjusts each variant of
TypedTransaction
to contain thechain_id
, and removeschain_id
it from therlp_signed
andsighash
functions.Fixes #561
PR Checklist