Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(providers): doc test for dev_rpc #857

Merged
merged 1 commit into from Feb 2, 2022
Merged

fix(providers): doc test for dev_rpc #857

merged 1 commit into from Feb 2, 2022

Conversation

wolflo
Copy link
Contributor

@wolflo wolflo commented Feb 2, 2022

Motivation

The doc test for the dev_rpc mod was failing when run directly from ethers_providers, because tokio's rt-multi-thread feature is not enabled.

Solution

Specify the current_thread runtime flavor instead.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

mattsse
mattsse approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@gakonst gakonst merged commit 885aa9c into gakonst:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wolflo @mattsse @gakonst