feat(solc): add Reporter type #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Feb 8, 2022
| let output = solc.compile(&input)?; | ||
|
|
||
| report::solc_spawn(&solc, &version, &input); | ||
| let output = solc.compile_exact(&input)?; |
There was a problem hiding this comment.
drive by fix to make it the same as in the parallel version, since the input already includes the sources and all its imports we want to limit the output to exactly those.
mattsse
force-pushed
the
matt/solc-reporter
branch
from
b35af67
to
afa3c5d
Compare
exactly, if we need more verbosity we can simply implement another reporter |
|
will fix all cargo warnings in a follow up, there are a bunch of those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref foundry-rs/foundry#628
Povide a way to emit custom output at certain points in the compiler pipeline
Solution
use a global
Reporterthat gets invoked in the code, theReportercan the invoked exactly onceethers_solc::report::init(BasicStdoutReporter::default());PR Checklist