Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(solc): consistent serde for linked and unlinked bytecode #948

Merged
merged 1 commit into from Feb 22, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 22, 2022

Motivation

Fix foundry-rs/foundry#787

Solution

Always prefix bytecode object with "0x"

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always 0x sounds good

@gakonst gakonst merged commit 60515d9 into gakonst:master Feb 22, 2022
gakonst added a commit to foundry-rs/foundry that referenced this pull request Feb 22, 2022
parse fantom gakonst/ethers-rs#941
fix flattening gakonst/ethers-rs#946
consistent bytecode prefixing gakonst/ethers-rs#948
charisma98 added a commit to charisma98/foundry that referenced this pull request Mar 4, 2023
parse fantom gakonst/ethers-rs#941
fix flattening gakonst/ethers-rs#946
consistent bytecode prefixing gakonst/ethers-rs#948
0129general added a commit to 0129general/FoundryProject that referenced this pull request May 8, 2024
parse fantom gakonst/ethers-rs#941
fix flattening gakonst/ethers-rs#946
consistent bytecode prefixing gakonst/ethers-rs#948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0x prefix inconsistent in object
2 participants