Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solc): flatten nodes only once #995

Merged
merged 1 commit into from Mar 8, 2022
Merged

fix(solc): flatten nodes only once #995

merged 1 commit into from Mar 8, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 7, 2022

Motivation

foundry-rs/foundry#811

Solution

Moved the insert above the recursive function, which should guarantee that we include a node only once.

Which would prevent A import B imports A which would start recursive flatten_node at B but A is not yet included in the imports set so it will be included again.

CC @rkrasiuk

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse mattsse changed the title test: add unique flatten test fix(solc): flatten nodes only once Mar 7, 2022
gakonst
gakonst approved these changes Mar 8, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix

@gakonst gakonst merged commit fab3088 into gakonst:master Mar 8, 2022
@onbjerg onbjerg mentioned this pull request Apr 18, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattsse @gakonst