Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interface design of WebGLEngine #618

Closed
eyworldwide opened this issue Dec 17, 2021 · 1 comment · Fixed by #722
Closed

New interface design of WebGLEngine #618

eyworldwide opened this issue Dec 17, 2021 · 1 comment · Fixed by #722
Assignees
Labels
design engine design high priority High priority issue
Milestone

Comments

@eyworldwide
Copy link
Member

eyworldwide commented Dec 17, 2021

Is your feature request related to a problem? Please describe.
image
The parameters of WebGLEngine are strange, especially I have to pass a undefined value to the second parameter when I want to set the canvas's property:

new WebGLEngine('canvasId', undefined, {alpha: true})

Describe the solution you'd like

Physics is a system of engine, maybe we should add system concept to engine, the API is like this:

webglEngine.addSystem(PhysxSystem);

The interface of System is more scalable, and we can add more systems in the future.

Design: @GuoLei1990

PR: @GuoLei1990

PR reviewers: @GuoLei1990 , @yangfengzzz , @eyworldwide

@eyworldwide eyworldwide changed the title New interface of WebGLEngine New interface design of WebGLEngine Dec 17, 2021
@GuoLei1990
Copy link
Member

How to say, the physical parameters here are not the physical system itself. The second is what kind of physical backend should be used.

But the problem you described is worth solving.

@GuoLei1990 GuoLei1990 added this to the 0.7 milestone Jan 28, 2022
@GuoLei1990 GuoLei1990 added design engine design high priority High priority issue physics Engine's physical system labels Jan 28, 2022
@GuoLei1990 GuoLei1990 removed the physics Engine's physical system label Feb 7, 2022
@GuoLei1990 GuoLei1990 linked a pull request Apr 1, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design engine design high priority High priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants