Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi scene rendering #1571

Merged
merged 36 commits into from
May 31, 2023
Merged

Support multi scene rendering #1571

merged 36 commits into from
May 31, 2023

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented May 25, 2023 •
edited

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Major improvement:

  • Support simultaneous multi-scene rendering
  • Physics simulation adjusted to be scene independent
  • Component support _onEnableInScene()/_onDisableInScene(), scene add/remove will not cause component queue changed, improve performance

Example and docs PR: galacean/galacean.github.io#745

@GuoLei1990 GuoLei1990 changed the title tsupport multi scene rendering Support multi scene rendering May 25, 2023
@GuoLei1990 GuoLei1990 marked this pull request as draft May 25, 2023 16:58
@GuoLei1990 GuoLei1990 added the enhancement New feature or request label May 26, 2023
@GuoLei1990 GuoLei1990 added this to the 1.1 milestone May 26, 2023
@GuoLei1990 GuoLei1990 self-assigned this May 26, 2023
@GuoLei1990 GuoLei1990 marked this pull request as ready for review May 26, 2023 15:10
@GuoLei1990 GuoLei1990 changed the base branch from main to dev/1.1 May 27, 2023 10:35
@GuoLei1990
Merge commit 'f0fdb2452be9d50404c1cd860e339a69423b47b5' into PR/suppo…
6177095 
…rt-multi-scene-rendering

* commit 'f0fdb2452be9d50404c1cd860e339a69423b47b5':
  ci: faster with lock & better practice by github actions (galacean#1508)
  fix: material reference count bug (galacean#1570)
  Fix memory leak (galacean#1562)
@GuoLei1990
refactor: temp modify
fccfb39
@GuoLei1990
refactor: revert temp code
74938b5
cptbtptpbcptdtptp
cptbtptpbcptdtptp approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 8b6fa74 into galacean:dev/1.1 May 31, 2023
@GuoLei1990 GuoLei1990 added the rendering Rendering related functions label May 31, 2023
@GuoLei1990 GuoLei1990 mentioned this pull request May 31, 2023
Closed
@GuoLei1990 GuoLei1990 deleted the PR/support-multi-scene-rendering branch September 18, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptbtptpbcptdtptp cptbtptpbcptdtptp cptbtptpbcptdtptp approved these changes

@yangfengzzz yangfengzzz Awaiting requested review from yangfengzzz

Assignees

@GuoLei1990 GuoLei1990

Labels
enhancement New feature or request rendering Rendering related functions
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GuoLei1990 @cptbtptpbcptdtptp