Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderLab add UsePass directive #1744

Merged
merged 20 commits into from
Sep 13, 2023
Merged

Conversation

Sway007
Copy link
Member

@Sway007 Sway007 commented Sep 11, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Use the UsePass directive to reference builtin or custom Shader Pass
  • Specify render queue by RenderQueueType
...
SubShader "demo" {
    ...
    UsePass "pbr/Default/Forward";

    Pass "Forward" {
      ...
      RenderQueueType = RenderQueueType.Transparent;
      ...
    }
    ...
}

@Sway007 Sway007 added the shader Shader related functions label Sep 11, 2023
@Sway007 Sway007 self-assigned this Sep 11, 2023
@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 35.82% and project coverage change: +5.62% 🎉

Comparison is base (863a4a5) 59.42% compared to head (27577bf) 65.04%.
Report is 19 commits behind head on dev/1.1.

❗ Current head 27577bf differs from pull request most recent head 0ce3c66. Consider uploading reports for the commit 0ce3c66 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.1    #1744      +/-   ##
===========================================
+ Coverage    59.42%   65.04%   +5.62%     
===========================================
  Files          424      470      +46     
  Lines        20248    23552    +3304     
  Branches      3274     3338      +64     
===========================================
+ Hits         12032    15319    +3287     
- Misses        7008     7029      +21     
+ Partials      1208     1204       -4     
Files Changed Coverage Δ
packages/core/src/animation/AnimationClip.ts 42.85% <0.00%> (-1.59%) ⬇️
packages/core/src/animation/Keyframe.ts 100.00% <ø> (ø)
...ore/src/animation/animationCurve/AnimationCurve.ts 61.42% <0.00%> (+7.46%) ⬆️
packages/core/src/asset/AssetType.ts 100.00% <ø> (ø)
packages/core/src/shader/Shader.ts 15.83% <0.00%> (+0.73%) ⬆️
packages/core/src/shader/ShaderData.ts 82.35% <ø> (+7.99%) ⬆️
...ges/core/src/shader/enums/RenderStateElementKey.ts 100.00% <ø> (ø)
packages/core/src/shaderlib/ShaderLib.ts 100.00% <ø> (ø)
packages/core/src/texture/RenderTarget.ts 57.89% <0.00%> (+2.99%) ⬆️
packages/loader/src/AnimationClipLoader.ts 16.66% <0.00%> (-33.34%) ⬇️
... and 107 more

... and 244 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 25367c0 into galacean:dev/1.1 Sep 13, 2023
4 of 5 checks passed
@GuoLei1990 GuoLei1990 added this to the 1.1 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shader Shader related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants