Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that the first frame of pointer's deltaPosition is incorrect #1749

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

Need to assign a value to the Position when initializing a Pointer.

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 12, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added bug Something isn't working Input Input related functions labels Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 91.42% and project coverage change: -0.81% ⚠️

Comparison is base (5d7d8dc) 61.91% compared to head (d761367) 61.10%.

❗ Current head d761367 differs from pull request most recent head df3eb82. Consider uploading reports for the commit df3eb82 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.1    #1749      +/-   ##
===========================================
- Coverage    61.91%   61.10%   -0.81%     
===========================================
  Files          464      464              
  Lines        20935    20926       -9     
  Branches      3386     3382       -4     
===========================================
- Hits         12961    12786     -175     
- Misses        6777     6956     +179     
+ Partials      1197     1184      -13     
Files Changed Coverage Δ
packages/core/src/input/pointer/PointerManager.ts 91.90% <91.42%> (+2.89%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added this to the 1.1 milestone Sep 13, 2023
@GuoLei1990 GuoLei1990 merged commit 7a1cd4a into galacean:dev/1.1 Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Input Input related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants