Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background abnormal when there are multiple scenes #1773

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

No description provided.

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 19, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added the bug Something isn't working label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: -0.05% ⚠️

Comparison is base (8c4cffc) 65.08% compared to head (e5b333a) 65.03%.

❗ Current head e5b333a differs from pull request most recent head 5603b0d. Consider uploading reports for the commit 5603b0d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
- Coverage   65.08%   65.03%   -0.05%     
==========================================
  Files         473      473              
  Lines       23620    23623       +3     
  Branches     3353     3353              
==========================================
- Hits        15372    15364       -8     
- Misses       7047     7057      +10     
- Partials     1201     1202       +1     
Files Changed Coverage Δ
packages/core/src/Engine.ts 87.21% <ø> (-0.17%) ⬇️
...ges/core/src/RenderPipeline/BasicRenderPipeline.ts 55.84% <0.00%> (ø)
packages/core/src/Background.ts 52.63% <90.90%> (+4.80%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cptbtptpbcptdtptp cptbtptpbcptdtptp changed the title Fix background abnormal when multiple scenes are activated Fix background abnormal when there are multiple scenes Sep 19, 2023
@GuoLei1990 GuoLei1990 merged commit a15563f into galacean:main Sep 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When there are multiple scenes, the rendering background is abnormal
2 participants