Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a series of physics bug #1777

Merged
merged 21 commits into from
Sep 22, 2023
Merged

Fix a series of physics bug #1777

merged 21 commits into from
Sep 22, 2023

Conversation

luzhuang
Copy link
Contributor

@luzhuang luzhuang commented Sep 20, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • fix: isKinematic bug when set transform
  • fix: physics clone error and setMaterial error
  • fix: HingeJoint set motor error
  • fix: HingeJoint getAngle and getVelocity error
  • fix: raycast error when charactorController enabled=false and CharactorController position set error

What is the current behavior? (You can also link to an open issue here)

@luzhuang luzhuang changed the title fix: isKinematic bug when set transform and clone promblem fix: isKinematic bug when set transform and clone promblem and setMaterial error Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 54.02% and project coverage change: -0.01% ⚠️

Comparison is base (c26f42c) 65.04% compared to head (fb2ef5d) 65.04%.
Report is 14 commits behind head on main.

❗ Current head fb2ef5d differs from pull request most recent head d48d4df. Consider uploading reports for the commit d48d4df to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1777      +/-   ##
==========================================
- Coverage   65.04%   65.04%   -0.01%     
==========================================
  Files         473      473              
  Lines       23641    23760     +119     
  Branches     3362     3366       +4     
==========================================
+ Hits        15378    15455      +77     
- Misses       7057     7104      +47     
+ Partials     1206     1201       -5     
Files Changed Coverage Δ
packages/core/src/particle/ParticleGenerator.ts 4.53% <ø> (ø)
...re/src/particle/modules/ParticleGeneratorModule.ts 25.00% <ø> (ø)
packages/core/src/physics/CharacterController.ts 54.09% <ø> (-0.75%) ⬇️
packages/core/src/physics/joint/FixedJoint.ts 40.00% <0.00%> (ø)
packages/core/src/physics/DynamicCollider.ts 39.16% <6.25%> (-5.07%) ⬇️
packages/core/src/physics/joint/Joint.ts 3.84% <6.66%> (+1.52%) ⬆️
packages/core/src/physics/joint/HingeJoint.ts 5.55% <9.09%> (+1.20%) ⬆️
packages/core/src/physics/joint/SpringJoint.ts 6.97% <10.00%> (+1.42%) ⬆️
...ges/core/src/physics/shape/CapsuleColliderShape.ts 45.45% <20.00%> (-7.49%) ⬇️
...ackages/physics-physx/src/joint/PhysXHingeJoint.ts 29.41% <25.00%> (-0.32%) ⬇️
... and 20 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luzhuang luzhuang changed the title fix: isKinematic bug when set transform and clone promblem and setMaterial error Fix a serious physics bug Sep 20, 2023
@luzhuang luzhuang changed the title Fix a serious physics bug Fix a series of physics bug Sep 20, 2023
@GuoLei1990 GuoLei1990 added bug Something isn't working animation Built-in animation system related functions labels Sep 21, 2023
@GuoLei1990 GuoLei1990 added physics Engine's physical system and removed animation Built-in animation system related functions labels Sep 22, 2023
@GuoLei1990 GuoLei1990 merged commit 461d2e2 into galacean:main Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working physics Engine's physical system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants