Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when background destroy #1781

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

  • this.texture = null; needs to be in front of this._material = null;
  • add unit test

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 20, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added the bug Something isn't working label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b499f94) 65.10% compared to head (a185ff7) 65.11%.

❗ Current head a185ff7 differs from pull request most recent head 26423ae. Consider uploading reports for the commit 26423ae to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   65.10%   65.11%           
=======================================
  Files         473      473           
  Lines       23641    23641           
  Branches     3362     3362           
=======================================
+ Hits        15392    15394    +2     
- Misses       7045     7047    +2     
+ Partials     1204     1200    -4     
Files Changed Coverage Δ
packages/core/src/Background.ts 59.21% <100.00%> (+6.57%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 changed the title Fixed issue with background destruction Fix error when background destroy Sep 20, 2023
@GuoLei1990 GuoLei1990 merged commit 48e3f40 into galacean:main Sep 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants