Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complement the syntax of break and continue statement #1789

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

Sway007
Copy link
Member

@Sway007 Sway007 commented Sep 21, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Complement the syntax of break and continue statement

@Sway007 Sway007 added the shader Shader related functions label Sep 21, 2023
@Sway007 Sway007 self-assigned this Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (16f8f2c) 65.13% compared to head (7cf24e3) 65.19%.

❗ Current head 7cf24e3 differs from pull request most recent head 8c2197a. Consider uploading reports for the commit 8c2197a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
+ Coverage   65.13%   65.19%   +0.05%     
==========================================
  Files         473      473              
  Lines       23641    23663      +22     
  Branches     3362     3362              
==========================================
+ Hits        15399    15427      +28     
+ Misses       7036     7033       -3     
+ Partials     1206     1203       -3     
Files Changed Coverage Δ
packages/shader-lab/src/ShaderVisitor.ts 87.50% <100.00%> (+0.43%) ⬆️
packages/shader-lab/src/ast-node/AstNode.ts 81.86% <100.00%> (+0.31%) ⬆️
packages/shader-lab/src/parser/ShaderParser.ts 98.80% <100.00%> (+0.01%) ⬆️
...kages/shader-lab/src/parser/tokens/GLSLKeywords.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 34d63e6 into galacean:main Sep 21, 2023
5 checks passed
@GuoLei1990 GuoLei1990 added the bug Something isn't working label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shader Shader related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants