Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DisorderedArray.foreach error when looping #1791

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

And add unit test.

@cptbtptpbcptdtptp cptbtptpbcptdtptp added the bug Something isn't working label Sep 21, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 70.29% and project coverage change: -0.08% ⚠️

Comparison is base (34d63e6) 65.24% compared to head (f9430a2) 65.17%.
Report is 1 commits behind head on main.

❗ Current head f9430a2 differs from pull request most recent head 9207521. Consider uploading reports for the commit 9207521 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   65.24%   65.17%   -0.08%     
==========================================
  Files         473      473              
  Lines       23663    23693      +30     
  Branches     3362     3363       +1     
==========================================
+ Hits        15440    15442       +2     
- Misses       7023     7050      +27     
- Partials     1200     1201       +1     
Files Changed Coverage Δ
packages/core/src/ComponentsManager.ts 78.99% <66.66%> (-1.88%) ⬇️
packages/core/src/input/pointer/Pointer.ts 87.80% <68.75%> (-12.20%) ⬇️
packages/core/src/physics/PhysicsScene.ts 77.97% <68.75%> (-6.00%) ⬇️
packages/core/src/DisorderedArray.ts 85.33% <81.25%> (+9.57%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 234a96c into galacean:main Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants