Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blendShape animation #1792

Merged
merged 27 commits into from
Sep 22, 2023
Merged

Fix blendShape animation #1792

merged 27 commits into from
Sep 22, 2023

Conversation

luzhuang
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Sep 22, 2023
@GuoLei1990 GuoLei1990 added the animation Built-in animation system related functions label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.05% ⚠️

Comparison is base (461d2e2) 65.12% compared to head (fb30756) 65.07%.

❗ Current head fb30756 differs from pull request most recent head 6dd2af3. Consider uploading reports for the commit 6dd2af3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   65.12%   65.07%   -0.05%     
==========================================
  Files         473      473              
  Lines       23760    23762       +2     
  Branches     3366     3367       +1     
==========================================
- Hits        15473    15463      -10     
- Misses       7091     7098       +7     
- Partials     1196     1201       +5     
Files Changed Coverage Δ
...nternal/animationCurveOwner/AnimationCurveOwner.ts 45.12% <22.22%> (+1.37%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 0ed54b2 into galacean:main Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants