Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Renderer._bounds clone bug #1797

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

import { WebGLEngine, MeshRenderer } from "@galacean/engine";

WebGLEngine.create({ canvas: "canvas" }).then((engine) => {
  engine.canvas.resizeByClientSize();
  const entity = engine.sceneManager.activeScene.createRootEntity("renderer");
  const renderer = entity.addComponent(MeshRenderer);
  console.log(
    "compare",
    entity.clone().getComponent(MeshRenderer)?.bounds.min ===
      renderer.bounds.min
  );
});

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 25, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp added the bug Something isn't working label Sep 25, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp changed the title fix Renderer._bounds clone bug Fix Renderer._bounds clone bug Sep 25, 2023
@GuoLei1990 GuoLei1990 merged commit ad0fcaa into galacean:main Sep 26, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants