Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scene still rendering when isActive = false #1804

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix scene still rendering when isActive = false #1804

merged 2 commits into from
Oct 6, 2023

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Oct 6, 2023
@GuoLei1990 GuoLei1990 merged commit 54564b9 into galacean:main Oct 6, 2023
4 of 5 checks passed
@GuoLei1990 GuoLei1990 linked an issue Oct 6, 2023 that may be closed by this pull request
Bug: scene.isActive = false but it is rendered all the time #1796
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptbtptpbcptdtptp cptbtptpbcptdtptp Awaiting requested review from cptbtptpbcptdtptp

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: scene.isActive = false but it is rendered all the time
1 participant
@GuoLei1990