Support anisotropy in pbr #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
+ Coverage 65.00% 65.05% +0.05%
==========================================
Files 473 473
Lines 23770 23782 +12
Branches 3370 3373 +3
==========================================
+ Hits 15452 15472 +20
+ Misses 7114 7112 -2
+ Partials 1204 1198 -6
☔ View full report in Codecov by Sentry. |
GuoLei1990
reviewed
Dec 26, 2023
GuoLei1990
reviewed
Dec 26, 2023
GuoLei1990
reviewed
Dec 26, 2023
GuoLei1990
reviewed
Dec 26, 2023
GuoLei1990
reviewed
Dec 26, 2023
GuoLei1990
reviewed
Dec 26, 2023
GuoLei1990
approved these changes
Dec 26, 2023
|
|
||
| #ifdef MATERIAL_ENABLE_ANISOTROPY | ||
| uniform vec3 material_AnisotropyInfo; | ||
| #endif |
There was a problem hiding this comment.
#ifdef MATERIAL_ENABLE_ANISOTROPY
uniform vec3 material_AnisotropyInfo;
#ifdef MATERIAL_HAS_ANISOTROPY_TEXTURE
uniform sampler2D material_AnisotropyTexture;
#endif
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
support #934 , merge conflict from #1345 ， playground: #854
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: