Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop error caused by shader cache bug #1815

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Oct 11, 2023
@GuoLei1990 GuoLei1990 self-assigned this Oct 11, 2023
@GuoLei1990 GuoLei1990 added the shader Shader related functions label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e659ea6) 65.04% compared to head (2de31de) 65.08%.

❗ Current head 2de31de differs from pull request most recent head b0d29da. Consider uploading reports for the commit b0d29da to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1815      +/-   ##
==========================================
+ Coverage   65.04%   65.08%   +0.03%     
==========================================
  Files         473      473              
  Lines       23770    23771       +1     
  Branches     3370     3369       -1     
==========================================
+ Hits        15462    15472      +10     
+ Misses       7110     7102       -8     
+ Partials     1198     1197       -1     
Files Coverage Δ
packages/core/src/shader/ShaderProgramPool.ts 71.05% <58.82%> (+0.78%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 8ce002a into galacean:main Oct 12, 2023
5 checks passed
@GuoLei1990 GuoLei1990 deleted the pr/fix-shader-cache-bug branch November 8, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shader Shader related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants