Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export IGLTF and support scene plugin #1816

Merged
merged 7 commits into from
Oct 13, 2023

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@zhuxudong zhuxudong added the enhancement New feature or request label Oct 12, 2023
@zhuxudong zhuxudong self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (89a417f) 65.07% compared to head (7617b53) 65.02%.

❗ Current head 7617b53 differs from pull request most recent head 058f525. Consider uploading reports for the commit 058f525 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   65.07%   65.02%   -0.05%     
==========================================
  Files         473      473              
  Lines       23771    23773       +2     
  Branches     3369     3369              
==========================================
- Hits        15468    15459       -9     
- Misses       7103     7113      +10     
- Partials     1200     1201       +1     
Files Coverage Δ
packages/loader/src/GLTFLoader.ts 100.00% <100.00%> (+14.28%) ⬆️
.../src/gltf/extensions/KHR_draco_mesh_compression.ts 4.67% <ø> (ø)
packages/loader/src/gltf/parser/GLTFMeshParser.ts 69.71% <ø> (ø)
...ckages/loader/src/gltf/parser/GLTFParserContext.ts 95.16% <100.00%> (ø)
packages/loader/src/gltf/parser/GLTFSceneParser.ts 57.93% <100.00%> (+0.58%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhuxudong zhuxudong changed the title Export IGLTF variable and support custom parser Export IGLTF and support scene plugin Oct 13, 2023
@GuoLei1990 GuoLei1990 merged commit 249e2cb into galacean:main Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants