Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VertexData2D.triangles reference error when change DrawMode to Tiled #1817

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@cptbtptpbcptdtptp cptbtptpbcptdtptp added bug Something isn't working sprite 2D Sprite labels Oct 16, 2023
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (249e2cb) 65.09% compared to head (ba6ef22) 65.01%.
Report is 1 commits behind head on main.

❗ Current head ba6ef22 differs from pull request most recent head 60f58c2. Consider uploading reports for the commit 60f58c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
- Coverage   65.09%   65.01%   -0.08%     
==========================================
  Files         473      473              
  Lines       23773    23757      -16     
  Branches     3368     3369       +1     
==========================================
- Hits        15475    15446      -29     
- Misses       7102     7113      +11     
- Partials     1196     1198       +2     
Files Coverage Δ
...ges/core/src/2d/assembler/SimpleSpriteAssembler.ts 95.00% <100.00%> (-0.13%) ⬇️
...ges/core/src/2d/assembler/SlicedSpriteAssembler.ts 96.61% <100.00%> (-0.69%) ⬇️
...ages/core/src/2d/assembler/TiledSpriteAssembler.ts 98.78% <100.00%> (+0.40%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 014de1d into galacean:main Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sprite 2D Sprite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants