Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix particle renderer bug #1834

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Oct 24, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Brust 运行时动态修改时间有 BUG, 不精准,需要类似 _frameRateTime 的机制。

@GuoLei1990 GuoLei1990 added bug Something isn't working particle labels Oct 24, 2023
@GuoLei1990 GuoLei1990 added this to the 1.2 milestone Oct 24, 2023
@GuoLei1990 GuoLei1990 merged commit da31c77 into galacean:main Oct 24, 2023
4 of 5 checks passed
@GuoLei1990 GuoLei1990 deleted the pr/fix-particle-bug branch October 24, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working particle
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ParticleRenderer destory cause GLBuffer error ParticleRenderer won't play after stop
2 participants