Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SkinnedMeshRenderer localBounds clone bug #1838

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

luzhuang
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@luzhuang luzhuang added the bug Something isn't working label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (437b374) 66.88% compared to head (6577e7d) 66.93%.

❗ Current head 6577e7d differs from pull request most recent head ce96052. Consider uploading reports for the commit ce96052 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   66.88%   66.93%   +0.05%     
==========================================
  Files         473      473              
  Lines       23757    23759       +2     
  Branches     3367     3368       +1     
==========================================
+ Hits        15889    15903      +14     
+ Misses       6671     6660      -11     
+ Partials     1197     1196       -1     
Files Coverage Δ
packages/core/src/clone/CloneManager.ts 78.84% <100.00%> (+0.84%) ⬆️
packages/core/src/clone/ComponentCloner.ts 85.71% <ø> (ø)
packages/core/src/mesh/SkinnedMeshRenderer.ts 64.37% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 changed the title fix: localBounds clone bug Fix SkinnedMeshRenderer localBounds clone bug Oct 26, 2023
@GuoLei1990 GuoLei1990 merged commit ace8596 into galacean:main Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mesh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants