Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor glTF BlendShape animation #1868

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Nov 7, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Related issues: KhronosGroup/glTF#1768

@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Nov 7, 2023
@GuoLei1990 GuoLei1990 added this to the 1.2 milestone Nov 7, 2023
@GuoLei1990 GuoLei1990 self-assigned this Nov 7, 2023
Copy link
Contributor

@luzhuang luzhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (98ead75) 66.67% compared to head (48a34c8) 66.71%.

❗ Current head 48a34c8 differs from pull request most recent head 1221915. Consider uploading reports for the commit 1221915 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.2    #1868      +/-   ##
===========================================
+ Coverage    66.67%   66.71%   +0.04%     
===========================================
  Files          472      472              
  Lines        23800    23799       -1     
  Branches      3394     3393       -1     
===========================================
+ Hits         15868    15878      +10     
+ Misses        6743     6731      -12     
- Partials      1189     1190       +1     
Files Coverage Δ
packages/core/src/Entity.ts 85.58% <100.00%> (ø)
...es/core/src/animation/AnimationClipCurveBinding.ts 80.95% <100.00%> (+0.95%) ⬆️
packages/core/src/animation/Animator.ts 64.31% <100.00%> (+1.45%) ⬆️
...nternal/animationCurveOwner/AnimationCurveOwner.ts 42.50% <66.66%> (+1.12%) ⬆️
...r/BlendShapeWeightsAnimationCurveOwnerAssembler.ts 62.50% <0.00%> (+17.04%) ⬆️
packages/core/src/animation/AnimationClip.ts 39.62% <55.55%> (-3.24%) ⬇️
...ages/loader/src/gltf/parser/GLTFAnimationParser.ts 58.19% <69.23%> (-1.98%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit f7bec17 into galacean:dev/1.2 Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation Built-in animation system related functions enhancement New feature or request glTF
Projects
No open projects
2 participants