Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the syntax for #include in ShaderLab #1952

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

Sway007
Copy link
Member

@Sway007 Sway007 commented Jan 8, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@Sway007 Sway007 self-assigned this Jan 8, 2024
@Sway007 Sway007 added the shader Shader related functions label Jan 8, 2024
@Sway007 Sway007 changed the title refactor: syntax for include code fragment refactor the syntax for #include in ShaderLab Jan 10, 2024
@Sway007 Sway007 added bug Something isn't working medium priority Medium priority issue labels Jan 10, 2024
@Sway007 Sway007 changed the title refactor the syntax for #include in ShaderLab Fix the syntax for #include in ShaderLab Jan 10, 2024
@GuoLei1990 GuoLei1990 added this to the 1.2 milestone Jan 10, 2024
@GuoLei1990 GuoLei1990 merged commit f04b98a into galacean:dev/1.2 Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority Medium priority issue shader Shader related functions
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants