Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera support custom view matrix #1954

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Camera support custom view matrix #1954

merged 3 commits into from
Jan 9, 2024

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Jan 9, 2024
@GuoLei1990 GuoLei1990 marked this pull request as draft January 9, 2024 03:49
@GuoLei1990 GuoLei1990 marked this pull request as ready for review January 9, 2024 05:53
@GuoLei1990 GuoLei1990 added this to the 1.2 milestone Jan 9, 2024
@GuoLei1990 GuoLei1990 linked an issue Jan 9, 2024 that may be closed by this pull request
需要支持修改相机的 View Matrix #1376
Closed
cptbtptpbcptdtptp
cptbtptpbcptdtptp approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit f694a17 into galacean:dev/1.2 Jan 9, 2024
6 checks passed
@GuoLei1990 GuoLei1990 changed the title Camera support custom view Camera support custom view matrix Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gz65555 gz65555 gz65555 approved these changes

@cptbtptpbcptdtptp cptbtptpbcptdtptp cptbtptpbcptdtptp approved these changes

@yuufen yuufen Awaiting requested review from yuufen

Assignees
No one assigned
Labels
camera enhancement New feature or request
Projects
No open projects
Milestone 1.2 iteration plan
Status: Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

需要支持修改相机的 View Matrix
3 participants
@GuoLei1990 @gz65555 @cptbtptpbcptdtptp