Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view dir in ortho projection #1962

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@zhuxudong zhuxudong added bug Something isn't working rendering Rendering related functions labels Jan 11, 2024
@zhuxudong zhuxudong added this to the 1.2 milestone Jan 11, 2024
@zhuxudong zhuxudong self-assigned this Jan 11, 2024
@zhuxudong
Copy link
Member Author

link issue: #636

@GuoLei1990 GuoLei1990 merged commit e1a511c into galacean:dev/1.2 Jan 12, 2024
6 checks passed
@GuoLei1990 GuoLei1990 linked an issue Jan 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rendering Rendering related functions
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Incorrect Specular Effect in Orthographic Camera
2 participants