Fix ShaderLab diagnostics position error when source include EditorProperties & EditorMacros module
#1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aderlab/position-offset
…/shaderlab/position-offset
Sway007
added
bug
…/shaderlab/position-offset
GuoLei1990
approved these changes
Jan 16, 2024
GuoLei1990
reviewed
Jan 16, 2024
| export class AstNodeUtils { | ||
| /** EditorProperties offset */ | ||
| static positionOffset: IPositionOffset[] | undefined; |
There was a problem hiding this comment.
Shouldn't cache instance data in Util class
GuoLei1990
approved these changes
Jan 16, 2024
GuoLei1990
changed the title
ShaderProgramPool._recursiveDestroy and ShaderLab diagnostics' postion info when source include EditorProperties & EditorMacros module ShaderLab diagnostics' position error when source include EditorProperties & EditorMacros module
GuoLei1990
changed the title
ShaderLab diagnostics' position error when source include EditorProperties & EditorMacros module ShaderLab diagnostics position error when source include EditorProperties & EditorMacros module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
ShaderLabsource includeEditorPropertiesandEditorMacrosmodule, the position of diagnostic ignore some line offset, now fixed.ShaderProgramPools._recursiveDestroywill run in a infinite loop when destroy shader